fix: improve error messages to include part number and descriptive context - #393
Open
dukunline-cyber wants to merge 1 commit into
Open
Conversation
…ntext - Include JLCPCB part number in all error messages - Add descriptive message when component exists on JLCPCB but not in EasyEDA database - Add test for C9900037709 (part not found in EasyEDA) Closes tscircuit#288
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #288
Changes
Before
Error: Component not found
After
Error: Component with JLCPCB part number C9900037709 not found in EasyEDA database. This part may exist on JLCPCB but lacks EasyEDA footprint data.
Testing
bun test tests/fetch-tests/c9900037709.test.ts passes